[PATCH] D67586: Replace uses of std::iterator with explicit typedefs

[Hamza Sood via Phabricator via llvm-commits]

hamzasood created this revision.
hamzasood added reviewers: MaskRay, bkramer, dexonsmith, mehdi_amini.
Herald added subscribers: llvm-commits, seiya, asbirlea, kristina, rupprecht, george.burgess.iv, hiraditya, MatzeB.
Herald added a project: LLVM.

This patch removes all uses of `std::iterator`, which was deprecated in C++17.
While this isn't currently an issue while compiling LLVM, it's useful for those using LLVM as a library.

For some reason there're a few places that were seemingly able to use `std` functions unqualified, which no longer works after this patch. I've updated those places, but I'm not really sure why it worked in the first place.


Repository:
  rL LLVM

https://reviews.llvm.org/D67586

Files:
  llvm/include/llvm/ADT/BreadthFirstIterator.h
  llvm/include/llvm/ADT/DepthFirstIterator.h
  llvm/include/llvm/ADT/EquivalenceClasses.h
  llvm/include/llvm/ADT/ImmutableSet.h
  llvm/include/llvm/ADT/IntervalMap.h
  llvm/include/llvm/ADT/PostOrderIterator.h
  llvm/include/llvm/ADT/SparseMultiSet.h
  llvm/include/llvm/ADT/iterator.h
  llvm/include/llvm/Analysis/AliasSetTracker.h
  llvm/include/llvm/Analysis/MemorySSA.h
  llvm/include/llvm/Analysis/RegionIterator.h
  llvm/include/llvm/CodeGen/MachineRegisterInfo.h
  llvm/include/llvm/CodeGen/ScheduleDAG.h
  llvm/include/llvm/CodeGen/SelectionDAGNodes.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h
  llvm/include/llvm/IR/CFG.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/include/llvm/IR/GetElementPtrTypeIterator.h
  llvm/include/llvm/IR/Metadata.h
  llvm/include/llvm/IR/Module.h
  llvm/include/llvm/IR/Value.h
  llvm/include/llvm/IR/ValueMap.h
  llvm/include/llvm/Object/ELFTypes.h
  llvm/include/llvm/Object/SymbolicFile.h
  llvm/include/llvm/ProfileData/Coverage/CoverageMappingReader.h
  llvm/include/llvm/ProfileData/InstrProfReader.h
  llvm/include/llvm/Support/LineIterator.h
  llvm/include/llvm/Support/TargetRegistry.h
  llvm/include/llvm/Support/YAMLParser.h
  llvm/include/llvm/TextAPI/MachO/ArchitectureSet.h
  llvm/include/llvm/Transforms/Scalar/GVNExpression.h
  llvm/lib/IR/BasicBlock.cpp
  llvm/tools/llvm-objdump/MachODump.cpp
  llvm/unittests/ADT/IteratorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67586.220221.patch
Type: text/x-patch
Size: 40150 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190914/e27d0655/attachment-0001.bin>