[PATCH] D67552: [LangRef] Clarify absence of rounding guarantees for fmuladd.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 14 08:07:06 PDT 2019
fhahn marked an inline comment as done.
fhahn added inline comments.
================
Comment at: llvm/docs/LangRef.rst:13954
is equivalent to the expression a \* b + c, except that rounding will
not be performed between the multiplication and addition steps if the
----------------
reames wrote:
> fhahn wrote:
> > reames wrote:
> > > Please change:
> > > "is equivalent to the expression a \* b + c, except that rounding will
> > > not be performed between the multiplication and addition steps if the
> > > code generator fuses the operations. "
> > >
> > > To:
> > > "is equivalent to the expression a \* b + c, except that it is unspecified whether rounding will be performed between the multiplication and addition steps. "
> > Sounds good, thanks! Do you think that clarification is enough, without the additional sentence?
> Yes. LGTM.
Done, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67552/new/
https://reviews.llvm.org/D67552
More information about the llvm-commits
mailing list