[PATCH] D67579: [PGO] Use linkonce_odr linkage for __profd_ variables in comdat groups

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 16:06:56 PDT 2019


xur accepted this revision.
xur added a comment.
This revision is now accepted and ready to land.

LGTM.  Thanks for the fix!

I wasn't sure why profd was set to internal when looking at PR41380 (as for ELF, all are linkonce_oda). But your description explained that.

BTW, the intrinsic lowering happens before inline (I suppose you are talking the main IPA inline).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67579/new/

https://reviews.llvm.org/D67579





More information about the llvm-commits mailing list