[PATCH] D67572: [SVFS] SearchVFSystem interface (WIP).

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

This is a follow up patch to https://reviews.llvm.org/D66024

It is a WIP becase I want to seek feedback before doing a full implementation with tests.

The current tests/unittests pass without failures, so at least it seems I haven't broken anything :)

I am in particular interested to know what you think about the way I have deferred the question "isFunctionVectorizable" and related "get" method from the `TargetLibraryInfo` (TLI). I have marched such methods as `private`, so that with this patch the only way to ask such questions around vectorizable function is to go through the `SearchVFSystem` class.

Notice that this patch doesn't implement the interface explained in the RFC at http://lists.llvm.org/pipermail/llvm-dev/2019-June/133484.html (yet).

One more thing: in the RFC we decided to pass the `CallInst` to the methods of the class instead of the `Function` definition, because we wanted to make the attribute `vector-function-abi-variant` to be local to the call site, not the declaration. Unfortunately, I couldn't find a way to attach an attribute to a `CallInst`. Is this the case? Or have I missed somethign around `Instruction`s and attributes?

Kind regards,

Francesco


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67572/new/

https://reviews.llvm.org/D67572