[PATCH] D67565: [NFC][libLTO] Rearrange declaration in lto.h

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 12:53:34 PDT 2019


steven_wu added a comment.

In D67565#1669913 <https://reviews.llvm.org/D67565#1669913>, @tejohnson wrote:

> In D67565#1669823 <https://reviews.llvm.org/D67565#1669823>, @steven_wu wrote:
>
> > Sorry, should be clear that this is for doxygen documents. See `@defgroup` `@ingroup` from the comments. Those functions where in the Caching APIs group.
> >
> > I don't see LLVM website is generating documents based on groups but still good to get it correct.
> >
> > Just want to clean this up because I am planning to add some new APIs.
>
>
> I get why they don't belong in the caching section, but now they are in the ThinLTO-specific section (LLVMCTLTO). Should they be in the earlier LLVMCLTO section which seems to include more of the generic LTO interfaces?


I got fooled by the `//endgroup` comment. I will fix that as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67565/new/

https://reviews.llvm.org/D67565





More information about the llvm-commits mailing list