[PATCH] D67566: [AArch64][GlobalISel] Tail call memory intrinsics

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h:98
 
+    /// True if the call was lowered as a tail call.
+    bool LoweredTailCall = false;
----------------
Can you make it clearer in this comment that it's done by the legalizer.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:335
+  AttributeList CallerAttrs = F.getAttributes();
+  if (AttrBuilder(CallerAttrs, AttributeList::ReturnIndex)
+          .removeAttribute(Attribute::NoAlias)
----------------
A comment here would be useful.


================
Comment at: llvm/test/CodeGen/AArch64/tailcall-mem-intrinsics.ll:2
 ; RUN: llc -mtriple=aarch64-unknown-unknown < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -mtriple=aarch64-unknown-unknown -global-isel < %s | FileCheck %s
 
----------------
-global-isel-abort=1?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67566/new/

https://reviews.llvm.org/D67566