[PATCH] D66843: Change datalayout compatibility check for X86 to allow datalayouts without the new address spaces.

Fri Sep 13 10:33:22 PDT 2019

kristina added a comment.

This seems to have been causing problems during linking, got hundreds of those:

  ld.lld: warning: Linking two modules of different data layouts: '/b/llvm-10/407/lib/libc++.a(cxa_exception.cpp.o at 5739456)' is 'e-m:e-i64:64-f80:128-n8:16:32:64-S128' whereas 'obj/gpr/third_party/protobuf/libprotoc_lib.a(libprotoc_lib.java_message_builder_lite.o at 10565644)' is 'e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128'

If this is only being used for `clang-cl` (or `-fms-compatibility`) mode only, is it possible to limit it to just that rather than it affecting pretty much everything?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66843/new/

https://reviews.llvm.org/D66843