[PATCH] D67558: [llvm-ar] Uncapitalize and delete full stop from error messages

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 09:26:22 PDT 2019


MaskRay added inline comments.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:386
     if (!Members.empty())
-      fail("The s operation takes only an archive as argument");
+      fail("the s operation takes only an archive as argument");
   }
----------------
grimar wrote:
> btw, below modifiers are sometimes wrapped into `''`. May be worth to make this consistent in messages while you are here too?
Wrapped in `''` for consistency.

It seems many error messages here are no tested. This is something we should improve in the future.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67558/new/

https://reviews.llvm.org/D67558





More information about the llvm-commits mailing list