[PATCH] D67529: [TextAPI] Introduce TBDv4

[Juergen Ributzka via Phabricator via llvm-commits]

ributzka added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/TextStub.cpp:741
 
+  static void setFileTypeForOutput(TextAPIContext *Ctx, IO &IO) {
+    if (IO.mapTag("!tapi-tbd", false))
----------------
I guess this should be called setFileTypeForInput, because this only gets called when a file is read.


================
Comment at: llvm/lib/TextAPI/MachO/TextStub.cpp:1060
+    IO.mapOptional("parent-umbrella", Keys->ParentUmbrellas);
+    unsigned c = 0;
+    IO.mapOptionalWithContext("allowable-clients", Keys->AllowableClients, c);
----------------
Please also update here with the new enum.


================
Comment at: llvm/lib/TextAPI/MachO/TextStub.cpp:1062
+    IO.mapOptionalWithContext("allowable-clients", Keys->AllowableClients, c);
+    c = 1;
+    IO.mapOptionalWithContext("reexported-libraries", Keys->ReexportedLibraries,
----------------
ditto


================
Comment at: llvm/unittests/TextAPI/TextStubV4Tests.cpp:221
+  File.setSwiftABIVersion(5);
+  File.addAllowableClient("ClientA", Targets.at(0));
+  File.addParentUmbrella(Targets.at(0), "System");
----------------
Why do you use .at() here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67529/new/

https://reviews.llvm.org/D67529