[PATCH] D66955: [DebugInfo][If-Converter] Update call site info during the optimization

Nikola Prica via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 08:16:43 PDT 2019


NikolaPrica updated this revision to Diff 220107.
NikolaPrica added a comment.

Thanks for the comment @efriedma! I've looked more carefully this optimization. It turns out that after `CopyAndPredicateBlock` it is not guaranteed that copied instruction block will be deleted. The deletion of critical call instruction happens after If-conversion during the BranchFolding cleaning when some block does not have predecessors.

Since we are not sure whether the block will be deleted after `CopyAndPredicateBlock` I've extended `updateCallSiteInfo` to be able to just make a copy of call site info.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66955/new/

https://reviews.llvm.org/D66955

Files:
  include/llvm/CodeGen/MachineFunction.h
  lib/CodeGen/BranchFolding.cpp
  lib/CodeGen/IfConversion.cpp
  lib/CodeGen/MachineFunction.cpp
  test/CodeGen/ARM/smml.ll
  test/DebugInfo/MIR/ARM/if-coverter-call-site-info.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66955.220107.patch
Type: text/x-patch
Size: 12264 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190913/22b2fbe8/attachment.bin>


More information about the llvm-commits mailing list