[PATCH] D66775: [libclang] Expose abort()-ing fatal error handler

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 13 05:32:36 PDT 2019


thakis added inline comments.


================
Comment at: cfe/trunk/unittests/libclang/CrashTests/CMakeLists.txt:1
+add_clang_unittest(libclangCrashTests
+  LibclangCrashTest.cpp
----------------
Can you add a comment on why this isn't just in libclangTests? I'm guessing it's to make sure the global error handler state doesn't accidentally link into the other tests in libclangTests, but I'm not sure.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66775/new/

https://reviews.llvm.org/D66775





More information about the llvm-commits mailing list