[PATCH] D63676: Disable hosting MI to hotter basic blocks

Fri Sep 13 05:03:13 PDT 2019

NeHuang marked 2 inline comments as done.
NeHuang added inline comments.

================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1572
+
+bool MachineLICMBase::IsHoistingFromColdToHotBlock(MachineBasicBlock *CurBB,
+    MachineBasicBlock *Preheader) {
----------------
NeHuang wrote:
> lei wrote:
> > nit: Most of the functions here use either `BB` or `MBB` for MachineBasicBlock variables.  IMHO unless there are diff BBs that are being tracked, I don't see why we need to specify this as "current"BB.  Just makes it easier to read when similar variables are being used consistently.
> Done
Done

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676