[PATCH] D67544: [TableGen] Support encoding and decoding per-HwMode

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D67544#1669238 <https://reviews.llvm.org/D67544#1669238>, @jmolloy wrote:

> Hi Roman,
>
> What are you referring to?
>
>   (a) This diff has not been submitted, it is a patch for code review.


Yep!

> If it doesn't have tests, that is something that can be mentioned in this review without being passive-aggressive.

For future reference, how those my two review comments are passive-aggressive?
>From where //i// stand that remark is.

>   (b) This diff has tests.

Cool, let's make that more obvious :)
Usually in most other cases that wording "NFC for in-tree targets" means something different..

> Cheers,
> 
> James




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67544/new/

https://reviews.llvm.org/D67544