[PATCH] D67533: [LNT] Python 3 support: Set up (client) setup requirements

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: requirements.client.txt:15
 pytz==2016.10
-wsgiref==0.1.2
+wsgiref==0.1.2;python_version<"3.0"
 WTForms==2.0.2
----------------
I believe this is part of Python 2.7 already. IMO the first thing to do in porting LNT would be to mandate Python 2.7 or later and add the 'Programming Language :: Python :: 2 :: Only' tag to setup.py


================
Comment at: setup.py:34
+    if sys.version_info[0] > 2:
+        req_file = "requirements-py3.client.txt"
+    else:
----------------
hubert.reinterpretcast wrote:
> This is unfortunate, but this `setup.py` is built off of `pip` internal interfaces (which I understand to be a departure from current best practices), and environment markers are not supported by older versions of `pip` anyway.
Indeed but this can be fixed after LNT is migrated to Python3 so I appreciate this immediate solution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67533/new/

https://reviews.llvm.org/D67533