[PATCH] D67504: [ELF] Make SHF_MERGE merging aware of output sections

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Generally the approach looks good to me. Lets see what other think.



================
Comment at: ELF/LinkerScript.h:171
 
+  std::vector<InputSectionBase *> sectionBases;
   std::vector<InputSection *> sections;
----------------
These 2 needs comment then I think.


================
Comment at: test/ELF/linkerscript/merge-output-sections.s:23
+# DIFF-NEXT: 0x00000000 01000200 0300
+# DIFF-NOT:  section
+# DIFF:      section '.rodata.bar':
----------------
Can you use `--implicit-check-not=section` instead (here and above)?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67504/new/

https://reviews.llvm.org/D67504