[PATCH] D67506: GSYM: add encoding and decoding to FunctionInfo

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: unittests/DebugInfo/GSYM/GSYMTest.cpp:28
+void checkError(ArrayRef<std::string> ExpectedMsgs, Error Err) {
+  ASSERT_TRUE(Err.operator bool());
+  size_t WhichMsg = 0;
----------------
`.operator bool()` may be an awkward way to call the overloaded operator.

`bool(Err)`


================
Comment at: unittests/DebugInfo/GSYM/GSYMTest.cpp:243
+  llvm::Expected<uint64_t> ExpectedOffset = FI.encode(FW);
+  ASSERT_TRUE(ExpectedOffset.operator bool());
+  // Verify we got the encoded offset back from the encode function.
----------------
`bool(ExpectedOffset)` or `!ExpectedOffset` (inversed)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67506/new/

https://reviews.llvm.org/D67506