[PATCH] D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.
Herald added subscribers: wuzish, MaskRay.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:464
+  /// Return true if instruction generated for ICMP_EQ could be folded with
+  /// instruction generated for ICMP_S(G|L)T
+  virtual bool isICMP_EQFoldedWithICMP_ST() const { return true; }
----------------
nit: missing `.` at the end of the sentence.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1409
 
+static bool foldICmpWithDominatingICmp(CmpInst *Cmp,
+                                       const TargetLowering &TLI) {
----------------
Please add a brief description for this function and some inline documentation so we can easily follow the logic.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:625
 
+    bool isICMP_EQFoldedWithICMP_ST() const override { return false; }
+
----------------
follow previous conventions and put `return false;` in the next line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60506/new/

https://reviews.llvm.org/D60506