[llvm] r371792 - LiveIntervals: Remove assertion

[Matt Arsenault via llvm-commits]

Author: arsenm
Date: Thu Sep 12 16:46:51 2019
New Revision: 371792

URL: http://llvm.org/viewvc/llvm-project?rev=371792&view=rev
Log:
LiveIntervals: Remove assertion

This testcase is invalid, and caught by the verifier. For the verifier
to catch it, the live interval computation needs to complete. Remove
the assert so the verifier catches this, which is less confusing.

In this testcase there is an undefined use of a subregister, and lanes
which aren't used or defined. An equivalent testcase with the
super-register shrunk to have no untouched lanes already hit this
verifier error.

Added:
    llvm/trunk/test/CodeGen/AMDGPU/at-least-one-def-value-assert.mir
Modified:
    llvm/trunk/lib/CodeGen/LiveInterval.cpp

Modified: llvm/trunk/lib/CodeGen/LiveInterval.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveInterval.cpp?rev=371792&r1=371791&r2=371792&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/LiveInterval.cpp (original)
+++ llvm/trunk/lib/CodeGen/LiveInterval.cpp Thu Sep 12 16:46:51 2019
@@ -917,7 +917,8 @@ static void stripValuesNotDefiningMask(u
   for (VNInfo *VNI : ToBeRemoved)
     SR.removeValNo(VNI);
 
-  assert(!SR.empty() && "At least one value should be defined by this mask");
+  // If the subrange is empty at this point, the MIR is invalid. Do not assert
+  // and let the verifier catch this case.
 }
 
 void LiveInterval::refineSubRanges(

Added: llvm/trunk/test/CodeGen/AMDGPU/at-least-one-def-value-assert.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/at-least-one-def-value-assert.mir?rev=371792&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/at-least-one-def-value-assert.mir (added)
+++ llvm/trunk/test/CodeGen/AMDGPU/at-least-one-def-value-assert.mir Thu Sep 12 16:46:51 2019
@@ -0,0 +1,28 @@
+# RUN: not llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx906 -verify-machineinstrs  -run-pass=machine-scheduler -verify-misched -o /dev/null %s  2>&1  | FileCheck %s
+
+# CHECK: *** Bad machine code: No live subrange at use ***
+# CHECK-NEXT: - function:    at_least_one_value_should_be_defined_by_this_mask
+# CHECK-NEXT: - basic block: %bb.0
+# CHECK-NEXT: - instruction: 48B	dead undef %2.sub0:vreg_128 = COPY %0.sub0:vreg_128
+# CHECK-NEXT: - operand 1:   %0.sub0:vreg_128
+# CHECK-NEXT: - interval:    %0 [16r,48r:0)  0 at 16r L00000002 [16r,32r:0)  0 at 16r weight:0.000000e+00
+
+# This used to assert with: !SR.empty() && "At least one value should be defined by this mask"
+
+# This MIR is invalid and should be caught by the verifier. %0.sub0 is
+# used, but not defined. There are also lanes in %0 that are not used
+# or defined anywhere. Previously there was an assertion in the
+# LiveInterval computation, which was more confusing. The invalid
+# LiveRange should be produced and the verifier will catch it.
+
+---
+name: at_least_one_value_should_be_defined_by_this_mask
+tracksRegLiveness: true
+body:             |
+  bb.0:
+
+    undef %0.sub1:vreg_128 = V_MOV_B32_e32 0, implicit $exec
+    %1:vreg_128 = COPY %0
+    undef %2.sub0:vreg_128 = COPY %0.sub0
+
+...