[PATCH] D67506: GSYM: add encoding and decoding to FunctionInfo

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

minor nits inline



================
Comment at: lib/DebugInfo/GSYM/FunctionInfo.cpp:18
 
+///< FunctionInfo information type that is used to encode the optional data
+///< that is associated with a FunctionInfo object.
----------------
this should be `///`; `///<` is for inline comments .


================
Comment at: lib/DebugInfo/GSYM/FunctionInfo.cpp:100
+  // Align FunctionInfo data to a 4 byte alignment.
+  O.alignTo(sizeof(uint32_t));
+  const uint64_t FuncInfoOffset = O.tell();
----------------
this seems pointless. I would just write 4.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67506/new/

https://reviews.llvm.org/D67506