[PATCH] D67513: [PowerPC] Remove the SPE4RC register class and instead add f32 to the GPRC register class.

[Justin Hibbits via Phabricator via llvm-commits]

jhibbits added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:2457
-       PPC::RESTORE_VRSAVE, PPC::QVLFDX, PPC::QVLFSXs, PPC::QVLFDXb,
-       PPC::SPILLTOVSR_LD}};
 
----------------
craig.topper wrote:
> jhibbits wrote:
> > Is this an extra change?  Doesn't look to be needed for the SPE4RC removal.
> This is related to the removal of SOK_SPE4Spill which caused SOK_LastOpcodeSpill to become one less so the entry in the array needed to be removed.
Not entirely.  The Power 9 block was not updated when SPE was added, only the Power 8 block was.  Your removal on the Power 9 blocks, in both load and store cases, is unnecessary, and would likely break things.  The only ones that should be removed are PPC::SPE*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67513/new/

https://reviews.llvm.org/D67513