[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 07:57:57 PDT 2019


courbet added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1024
     NextBlockOffset = BBInfo[Water->getNumber()].postOffset();
-    NextBlockLogAlignment = 0;
+    NextBlockAlignment = llvm::Align();
   } else {
----------------
this statement is now useless.


================
Comment at: llvm/lib/Target/Mips/MipsSERegisterInfo.cpp:216
+    const llvm::Align OffsetAlign =
+        llvm::Align(getLoadStoreOffsetAlign(MI.getOpcode()));
 
----------------
what about:

```
const llvm::Align OffsetAlign =
        llvm::Align(llvm::Align(getLoadStoreOffsetAlign(MI.getOpcode()))));
```

:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67499/new/

https://reviews.llvm.org/D67499





More information about the llvm-commits mailing list