[llvm] r371737 - [InstCombine][InstSimplify] Move constant-folding tests in result-of-usub-is-non-zero-and-no-overflow.ll
Roman Lebedev via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 12 07:12:31 PDT 2019
Author: lebedevri
Date: Thu Sep 12 07:12:31 2019
New Revision: 371737
URL: http://llvm.org/viewvc/llvm-project?rev=371737&view=rev
Log:
[InstCombine][InstSimplify] Move constant-folding tests in result-of-usub-is-non-zero-and-no-overflow.ll
Added:
llvm/trunk/test/Transforms/InstSimplify/result-of-usub-is-non-zero-and-no-overflow.ll
Modified:
llvm/trunk/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll
Modified: llvm/trunk/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll?rev=371737&r1=371736&r2=371737&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/result-of-usub-is-non-zero-and-no-overflow.ll Thu Sep 12 07:12:31 2019
@@ -287,148 +287,8 @@ define i1 @t9_commutative(i8 %base, i8 %
;-------------------------------------------------------------------------------
-; If we are checking that we either did not get null or got no overflow,
-; this is tautological and is always true.
-
-define i1 @t10(i8 %base, i8 %offset) {
+define i1 @t10(i64 %base, i64* nonnull %offsetptr) {
; CHECK-LABEL: @t10(
-; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
-; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
-; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp uge i8 [[BASE]], [[OFFSET]]
-; CHECK-NEXT: call void @use1(i1 [[NO_UNDERFLOW]])
-; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0
-; CHECK-NEXT: call void @use1(i1 [[NOT_NULL]])
-; CHECK-NEXT: [[R:%.*]] = or i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
-; CHECK-NEXT: ret i1 [[R]]
-;
- %adjusted = sub i8 %base, %offset
- call void @use8(i8 %adjusted)
- %no_underflow = icmp uge i8 %base, %offset
- call void @use1(i1 %no_underflow)
- %not_null = icmp ne i8 %adjusted, 0
- call void @use1(i1 %not_null)
- %r = or i1 %not_null, %no_underflow
- ret i1 %r
-}
-define i1 @t10_strict_bad(i8 %base, i8 %offset) {
-; CHECK-LABEL: @t10_strict_bad(
-; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
-; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
-; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp ugt i8 [[BASE]], [[OFFSET]]
-; CHECK-NEXT: call void @use1(i1 [[NO_UNDERFLOW]])
-; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0
-; CHECK-NEXT: call void @use1(i1 [[NOT_NULL]])
-; CHECK-NEXT: [[R:%.*]] = or i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
-; CHECK-NEXT: ret i1 [[R]]
-;
- %adjusted = sub i8 %base, %offset
- call void @use8(i8 %adjusted)
- %no_underflow = icmp ugt i8 %base, %offset ; but not for non-strict predicate
- call void @use1(i1 %no_underflow)
- %not_null = icmp ne i8 %adjusted, 0
- call void @use1(i1 %not_null)
- %r = or i1 %not_null, %no_underflow
- ret i1 %r
-}
-
-define i1 @t11(i8 %base, i8 %offset) {
-; CHECK-LABEL: @t11(
-; CHECK-NEXT: [[AGG:%.*]] = call { i8, i1 } @llvm.usub.with.overflow.i8(i8 [[BASE:%.*]], i8 [[OFFSET:%.*]])
-; CHECK-NEXT: call void @useagg({ i8, i1 } [[AGG]])
-; CHECK-NEXT: [[ADJUSTED:%.*]] = extractvalue { i8, i1 } [[AGG]], 0
-; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
-; CHECK-NEXT: [[UNDERFLOW:%.*]] = extractvalue { i8, i1 } [[AGG]], 1
-; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
-; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = xor i1 [[UNDERFLOW]], true
-; CHECK-NEXT: call void @use1(i1 [[NO_UNDERFLOW]])
-; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0
-; CHECK-NEXT: [[R:%.*]] = or i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
-; CHECK-NEXT: ret i1 [[R]]
-;
- %agg = call {i8, i1} @llvm.usub.with.overflow(i8 %base, i8 %offset)
- call void @useagg({i8, i1} %agg)
- %adjusted = extractvalue {i8, i1} %agg, 0
- call void @use8(i8 %adjusted)
- %underflow = extractvalue {i8, i1} %agg, 1
- call void @use1(i1 %underflow)
- %no_underflow = xor i1 %underflow, -1
- call void @use1(i1 %no_underflow)
- %not_null = icmp ne i8 %adjusted, 0
- %r = or i1 %not_null, %no_underflow
- ret i1 %r
-}
-
-; Likewise, if we are checking that we both got null and overflow happened,
-; it makes no sense and is always false.
-
-define i1 @t12(i8 %base, i8 %offset) {
-; CHECK-LABEL: @t12(
-; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
-; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
-; CHECK-NEXT: [[UNDERFLOW:%.*]] = icmp ult i8 [[BASE]], [[OFFSET]]
-; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
-; CHECK-NEXT: [[NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0
-; CHECK-NEXT: call void @use1(i1 [[NULL]])
-; CHECK-NEXT: [[R:%.*]] = and i1 [[NULL]], [[UNDERFLOW]]
-; CHECK-NEXT: ret i1 [[R]]
-;
- %adjusted = sub i8 %base, %offset
- call void @use8(i8 %adjusted)
- %underflow = icmp ult i8 %base, %offset
- call void @use1(i1 %underflow)
- %null = icmp eq i8 %adjusted, 0
- call void @use1(i1 %null)
- %r = and i1 %null, %underflow
- ret i1 %r
-}
-define i1 @t12_nonstrict_bad(i8 %base, i8 %offset) {
-; CHECK-LABEL: @t12_nonstrict_bad(
-; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
-; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
-; CHECK-NEXT: [[UNDERFLOW:%.*]] = icmp uge i8 [[ADJUSTED]], [[BASE]]
-; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
-; CHECK-NEXT: [[NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0
-; CHECK-NEXT: call void @use1(i1 [[NULL]])
-; CHECK-NEXT: [[R:%.*]] = and i1 [[NULL]], [[UNDERFLOW]]
-; CHECK-NEXT: ret i1 [[R]]
-;
- %adjusted = sub i8 %base, %offset
- call void @use8(i8 %adjusted)
- %underflow = icmp uge i8 %adjusted, %base ; but not for non-strict predicate
- call void @use1(i1 %underflow)
- %null = icmp eq i8 %adjusted, 0
- call void @use1(i1 %null)
- %r = and i1 %null, %underflow
- ret i1 %r
-}
-
-define i1 @t13(i8 %base, i8 %offset) {
-; CHECK-LABEL: @t13(
-; CHECK-NEXT: [[AGG:%.*]] = call { i8, i1 } @llvm.usub.with.overflow.i8(i8 [[BASE:%.*]], i8 [[OFFSET:%.*]])
-; CHECK-NEXT: call void @useagg({ i8, i1 } [[AGG]])
-; CHECK-NEXT: [[ADJUSTED:%.*]] = extractvalue { i8, i1 } [[AGG]], 0
-; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
-; CHECK-NEXT: [[UNDERFLOW:%.*]] = extractvalue { i8, i1 } [[AGG]], 1
-; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
-; CHECK-NEXT: [[NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0
-; CHECK-NEXT: [[R:%.*]] = and i1 [[NULL]], [[UNDERFLOW]]
-; CHECK-NEXT: ret i1 [[R]]
-;
- %agg = call {i8, i1} @llvm.usub.with.overflow(i8 %base, i8 %offset)
- call void @useagg({i8, i1} %agg)
- %adjusted = extractvalue {i8, i1} %agg, 0
- call void @use8(i8 %adjusted)
- %underflow = extractvalue {i8, i1} %agg, 1
- call void @use1(i1 %underflow)
- %null = icmp eq i8 %adjusted, 0
- %r = and i1 %null, %underflow
- ret i1 %r
-}
-
-;-------------------------------------------------------------------------------
-
-define i1 @t15(i64 %base, i64* nonnull %offsetptr) {
-; CHECK-LABEL: @t15(
; CHECK-NEXT: [[OFFSET:%.*]] = ptrtoint i64* [[OFFSETPTR:%.*]] to i64
; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i64 [[BASE:%.*]], [[OFFSET]]
; CHECK-NEXT: call void @use64(i64 [[ADJUSTED]])
@@ -450,8 +310,8 @@ define i1 @t15(i64 %base, i64* nonnull %
%r = and i1 %not_null, %no_underflow
ret i1 %r
}
-define i1 @t16_commutative(i64 %base, i64* nonnull %offsetptr) {
-; CHECK-LABEL: @t16_commutative(
+define i1 @t11_commutative(i64 %base, i64* nonnull %offsetptr) {
+; CHECK-LABEL: @t11_commutative(
; CHECK-NEXT: [[OFFSET:%.*]] = ptrtoint i64* [[OFFSETPTR:%.*]] to i64
; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i64 [[BASE:%.*]], [[OFFSET]]
; CHECK-NEXT: call void @use64(i64 [[ADJUSTED]])
@@ -474,8 +334,8 @@ define i1 @t16_commutative(i64 %base, i6
ret i1 %r
}
-define i1 @t17(i64 %base, i64* nonnull %offsetptr) {
-; CHECK-LABEL: @t17(
+define i1 @t12(i64 %base, i64* nonnull %offsetptr) {
+; CHECK-LABEL: @t12(
; CHECK-NEXT: [[OFFSET:%.*]] = ptrtoint i64* [[OFFSETPTR:%.*]] to i64
; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i64 [[BASE:%.*]], [[OFFSET]]
; CHECK-NEXT: call void @use64(i64 [[ADJUSTED]])
@@ -497,8 +357,8 @@ define i1 @t17(i64 %base, i64* nonnull %
%r = or i1 %not_null, %no_underflow
ret i1 %r
}
-define i1 @t18(i64 %base, i64* nonnull %offsetptr) {
-; CHECK-LABEL: @t18(
+define i1 @t13(i64 %base, i64* nonnull %offsetptr) {
+; CHECK-LABEL: @t13(
; CHECK-NEXT: [[OFFSET:%.*]] = ptrtoint i64* [[OFFSETPTR:%.*]] to i64
; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i64 [[BASE:%.*]], [[OFFSET]]
; CHECK-NEXT: call void @use64(i64 [[ADJUSTED]])
@@ -521,8 +381,8 @@ define i1 @t18(i64 %base, i64* nonnull %
ret i1 %r
}
-define i1 @t19_bad(i64 %base, i64 %offset) {
-; CHECK-LABEL: @t19_bad(
+define i1 @t14_bad(i64 %base, i64 %offset) {
+; CHECK-LABEL: @t14_bad(
; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i64 [[BASE:%.*]], [[OFFSET:%.*]]
; CHECK-NEXT: call void @use64(i64 [[ADJUSTED]])
; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp ult i64 [[ADJUSTED]], [[BASE]]
Added: llvm/trunk/test/Transforms/InstSimplify/result-of-usub-is-non-zero-and-no-overflow.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstSimplify/result-of-usub-is-non-zero-and-no-overflow.ll?rev=371737&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/InstSimplify/result-of-usub-is-non-zero-and-no-overflow.ll (added)
+++ llvm/trunk/test/Transforms/InstSimplify/result-of-usub-is-non-zero-and-no-overflow.ll Thu Sep 12 07:12:31 2019
@@ -0,0 +1,140 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt %s -instsimplify -S | FileCheck %s
+
+; Here we subtract two values, check that subtraction did not overflow AND
+; that the result is non-zero. This can be simplified just to a comparison
+; between the base and offset.
+
+declare void @use8(i8)
+declare void @use64(i64)
+declare void @use1(i1)
+
+declare void @llvm.assume(i1)
+
+; If we are checking that we either did not get null or got no overflow,
+; this is tautological and is always true.
+
+define i1 @t1(i8 %base, i8 %offset) {
+; CHECK-LABEL: @t1(
+; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
+; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
+; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp uge i8 [[BASE]], [[OFFSET]]
+; CHECK-NEXT: call void @use1(i1 [[NO_UNDERFLOW]])
+; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0
+; CHECK-NEXT: call void @use1(i1 [[NOT_NULL]])
+; CHECK-NEXT: [[R:%.*]] = or i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %adjusted = sub i8 %base, %offset
+ call void @use8(i8 %adjusted)
+ %no_underflow = icmp uge i8 %base, %offset
+ call void @use1(i1 %no_underflow)
+ %not_null = icmp ne i8 %adjusted, 0
+ call void @use1(i1 %not_null)
+ %r = or i1 %not_null, %no_underflow
+ ret i1 %r
+}
+define i1 @t1_strict_bad(i8 %base, i8 %offset) {
+; CHECK-LABEL: @t1_strict_bad(
+; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
+; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
+; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp ugt i8 [[BASE]], [[OFFSET]]
+; CHECK-NEXT: call void @use1(i1 [[NO_UNDERFLOW]])
+; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0
+; CHECK-NEXT: call void @use1(i1 [[NOT_NULL]])
+; CHECK-NEXT: [[R:%.*]] = or i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %adjusted = sub i8 %base, %offset
+ call void @use8(i8 %adjusted)
+ %no_underflow = icmp ugt i8 %base, %offset ; but not for non-strict predicate
+ call void @use1(i1 %no_underflow)
+ %not_null = icmp ne i8 %adjusted, 0
+ call void @use1(i1 %not_null)
+ %r = or i1 %not_null, %no_underflow
+ ret i1 %r
+}
+define i1 @t1_commutativity(i8 %base, i8 %offset) {
+; CHECK-LABEL: @t1_commutativity(
+; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
+; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
+; CHECK-NEXT: [[NO_UNDERFLOW:%.*]] = icmp ule i8 [[OFFSET]], [[BASE]]
+; CHECK-NEXT: call void @use1(i1 [[NO_UNDERFLOW]])
+; CHECK-NEXT: [[NOT_NULL:%.*]] = icmp ne i8 [[ADJUSTED]], 0
+; CHECK-NEXT: call void @use1(i1 [[NOT_NULL]])
+; CHECK-NEXT: [[R:%.*]] = or i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %adjusted = sub i8 %base, %offset
+ call void @use8(i8 %adjusted)
+ %no_underflow = icmp ule i8 %offset, %base
+ call void @use1(i1 %no_underflow)
+ %not_null = icmp ne i8 %adjusted, 0
+ call void @use1(i1 %not_null)
+ %r = or i1 %not_null, %no_underflow
+ ret i1 %r
+}
+
+; Likewise, if we are checking that we both got null and overflow happened,
+; it makes no sense and is always false.
+
+define i1 @t2(i8 %base, i8 %offset) {
+; CHECK-LABEL: @t2(
+; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
+; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
+; CHECK-NEXT: [[UNDERFLOW:%.*]] = icmp ult i8 [[BASE]], [[OFFSET]]
+; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
+; CHECK-NEXT: [[NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0
+; CHECK-NEXT: call void @use1(i1 [[NULL]])
+; CHECK-NEXT: [[R:%.*]] = and i1 [[NULL]], [[UNDERFLOW]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %adjusted = sub i8 %base, %offset
+ call void @use8(i8 %adjusted)
+ %underflow = icmp ult i8 %base, %offset
+ call void @use1(i1 %underflow)
+ %null = icmp eq i8 %adjusted, 0
+ call void @use1(i1 %null)
+ %r = and i1 %null, %underflow
+ ret i1 %r
+}
+define i1 @t2_nonstrict_bad(i8 %base, i8 %offset) {
+; CHECK-LABEL: @t2_nonstrict_bad(
+; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
+; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
+; CHECK-NEXT: [[UNDERFLOW:%.*]] = icmp uge i8 [[ADJUSTED]], [[BASE]]
+; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
+; CHECK-NEXT: [[NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0
+; CHECK-NEXT: call void @use1(i1 [[NULL]])
+; CHECK-NEXT: [[R:%.*]] = and i1 [[NULL]], [[UNDERFLOW]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %adjusted = sub i8 %base, %offset
+ call void @use8(i8 %adjusted)
+ %underflow = icmp uge i8 %adjusted, %base ; but not for non-strict predicate
+ call void @use1(i1 %underflow)
+ %null = icmp eq i8 %adjusted, 0
+ call void @use1(i1 %null)
+ %r = and i1 %null, %underflow
+ ret i1 %r
+}
+define i1 @t2_commutativity(i8 %base, i8 %offset) {
+; CHECK-LABEL: @t2_commutativity(
+; CHECK-NEXT: [[ADJUSTED:%.*]] = sub i8 [[BASE:%.*]], [[OFFSET:%.*]]
+; CHECK-NEXT: call void @use8(i8 [[ADJUSTED]])
+; CHECK-NEXT: [[UNDERFLOW:%.*]] = icmp ugt i8 [[OFFSET]], [[BASE]]
+; CHECK-NEXT: call void @use1(i1 [[UNDERFLOW]])
+; CHECK-NEXT: [[NULL:%.*]] = icmp eq i8 [[ADJUSTED]], 0
+; CHECK-NEXT: call void @use1(i1 [[NULL]])
+; CHECK-NEXT: [[R:%.*]] = and i1 [[NULL]], [[UNDERFLOW]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %adjusted = sub i8 %base, %offset
+ call void @use8(i8 %adjusted)
+ %underflow = icmp ugt i8 %offset, %base
+ call void @use1(i1 %underflow)
+ %null = icmp eq i8 %adjusted, 0
+ call void @use1(i1 %null)
+ %r = and i1 %null, %underflow
+ ret i1 %r
+}
More information about the llvm-commits
mailing list