[PATCH] D67482: [ELF][X86] Allow PT_LOAD to have overlapping p_offset ranges on EM_X86_64

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 12 02:18:10 PDT 2019


grimar added a comment.

I also think it is OK. I haven't check all the math, seems there are problems with it in some places.
But seems we never cared too much about it anyways.



================
Comment at: test/ELF/x86-64-tls-ie.s:33
 
-// 0x201000 + 4281 + 7 = 0x2020C0
-// 0x20100A + 4279 + 7 = 0x2020C8
-// 0x201014 + 4269 + 7 = 0x2020C8
+// 0x2012d0 + 4329 + 7 = 0x2023C8
+// 0x2012dA + 4327 + 7 = 0x2023D0
----------------
```
= 2023C0
```


================
Comment at: test/ELF/x86-64-tls-ie.s:34
+// 0x2012d0 + 4329 + 7 = 0x2023C8
+// 0x2012dA + 4327 + 7 = 0x2023D0
+// 0x2012e4 + 4317 + 7 = 0x2023D0
----------------
```
= 2023C8
```


================
Comment at: test/ELF/x86-64-tls-ie.s:35
+// 0x2012dA + 4327 + 7 = 0x2023D0
+// 0x2012e4 + 4317 + 7 = 0x2023D0
 // DISASM:      Disassembly of section .text:
----------------
```
= 2023C8
```


================
Comment at: test/ELF/x86-64-tlsdesc-ld.s:17
 
-## 0x20a0-0x1007 = 4249
+## 0x2318-0x1267 = 4249
 ## dtpoff(a) = 8, dtpoff(b) = 12
----------------
```
= 4273
```


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67482/new/

https://reviews.llvm.org/D67482





More information about the llvm-commits mailing list