[PATCH] D67481: [ELF] Add -z separate-segments to complement separate-code and noseparate-code

[Peter Smith via Phabricator via llvm-commits]

peter.smith added inline comments.


================
Comment at: ELF/Config.h:64
 
+// For -z noseparate-code, -z separate-code and -z separate-segment.
+enum class SeparateSegmentKind { None, Code, All };
----------------
MaskRay wrote:
> `separate-segment -> separate-segments`
> 
> Which one do you prefer?
Given that there is generally only one PF_X segment separate-code being singular makes sense. There can be more than one segment involved here so personally I'd use the plural form of separate-segments. It may also be worth being more specific with "--separate-loadable-segments" as I think that is more self descriptive, if a bit long.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67481/new/

https://reviews.llvm.org/D67481