[PATCH] D67479: [ELF] Support -z undefs

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Driver.cpp:390
+         s == "rodynamic" || s == "text" || s == "undefs" || s == "wxneeded" ||
          s.startswith("common-page-size") || s.startswith("max-page-size=") ||
          s.startswith("stack-size=");
----------------
MaskRay wrote:
> Unrelated to this change.
> 
> ```
> % ld.lld -z max-page-sizez a.o
> error: unknown -z value: max-page-sizez
> % ld.lld -z common-page-sizez a.o
> # No diagnostic "error: unknown -z value: common-page-sizez"
> ```
Yeah, it is perhaps better to tighten the check a bit to catch that error too.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67479/new/

https://reviews.llvm.org/D67479