[PATCH] D66084: Remove asserts in getLoopGuardBranch

[Dangeti Tharun kumar via Phabricator via llvm-commits]

DTharun marked an inline comment as done.
DTharun added inline comments.


================
Comment at: lib/Analysis/LoopInfo.cpp:373
+  // Loop should be in rotate form.
+  if (isLoopExiting(Latch))
+    return nullptr;
----------------
Whitney wrote:
> You want isLoopExiting(Latch)....so change to if (!isLoopExiting(Latch)) return;
> 
> Please undo all your changes to the test cases. 
> And add EXPECT_EQ(L->getLoopGuardBranch(), nullptr); to all test cases which has non simplified loops or non rotated loops in LoopInfoTest.cpp.
Ohh, thanks for the catch. I will fix it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66084/new/

https://reviews.llvm.org/D66084