[PATCH] D67479: [ELF] Support -z undefs

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: amosbird, grimar, peter.smith, ruiu.
Herald added subscribers: llvm-commits, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

-z undefs is the inverse of -z defs. It allows unresolved references
from object files. This can be used to cancel --no-undefined or -z defs.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D67479

Files:
  ELF/Driver.cpp
  test/ELF/zdefs.s


Index: test/ELF/zdefs.s
===================================================================
--- test/ELF/zdefs.s
+++ test/ELF/zdefs.s
@@ -1,9 +1,15 @@
 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
+
+## Unresolved references from object files are allowed by default for -shared.
 # RUN: ld.lld -shared %t.o -o %t1.so
 
+## -z defs disallows unresolved references.
 # RUN: not ld.lld -z defs -shared %t.o -o %t1.so 2>&1 | FileCheck -check-prefix=ERR %s
 # ERR: error: undefined symbol: foo
 # ERR: >>> referenced by {{.*}}:(.text+0x1)
 
+## -z undefs allows unresolved references.
+# RUN: ld.lld -z defs -z undefs -shared %t.o -o /dev/null 2>&1 | count 0
+
 callq foo at PLT
Index: ELF/Driver.cpp
===================================================================
--- ELF/Driver.cpp
+++ ELF/Driver.cpp
@@ -386,7 +386,7 @@
          s == "noexecstack" || s == "nokeep-text-section-prefix" ||
          s == "norelro" || s == "noseparate-code" || s == "notext" ||
          s == "now" || s == "origin" || s == "relro" || s == "retpolineplt" ||
-         s == "rodynamic" || s == "text" || s == "wxneeded" ||
+         s == "rodynamic" || s == "text" || s == "undefs" || s == "wxneeded" ||
          s.startswith("common-page-size") || s.startswith("max-page-size=") ||
          s.startswith("stack-size=");
 }
@@ -517,6 +517,8 @@
     case OPT_z:
       if (StringRef(arg->getValue()) == "defs")
         return errorOrWarn;
+      if (StringRef(arg->getValue()) == "undefs")
+        return UnresolvedPolicy::Ignore;
       continue;
     }
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67479.219847.patch
Type: text/x-patch
Size: 1584 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190912/2dd160f8/attachment.bin>