[PATCH] D66724: [AIX]Emit function descriptor csect in assembly
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 11 16:34:25 PDT 2019
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1678
+
+ ORE = &getAnalysis<MachineOptimizationRemarkEmitterPass>().getORE();
+}
----------------
Please add a comment to explain why this does not call the base class version of `SetupMachineFunction` and instead has some copy/paste. Alternatively, call the base class version if possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66724/new/
https://reviews.llvm.org/D66724
More information about the llvm-commits
mailing list