[PATCH] D67305: [AliasSetTracker] Update AAInfo check.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked 3 inline comments as done.
asbirlea added inline comments.


================
Comment at: include/llvm/Analysis/AliasSetTracker.h:87
         // We don't have a AAInfo yet. Set it to NewAAInfo.
         AAInfo = NewAAInfo;
+      else if (AAInfo.TBAA != NewAAInfo.TBAA ||
----------------
hfinkel wrote:
> asbirlea wrote:
> > hfinkel wrote:
> > > Given what we know about the code below, is this sound?
> > Would you mind elaborating?
> If an AAMD field going from non-null to null requires a merge, why does going from null to non-null not require a merge?
I don't think in this case we ever go from null to non-null.
It seems right after some thinking to do merge (set to null) when the fields are different vs tombstone key, so I updated below.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67305/new/

https://reviews.llvm.org/D67305