[llvm] r371666 - [DWARF] Emit call site parameter info when tuning for lldb
Vedant Kumar via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 11 14:23:39 PDT 2019
Author: vedantk
Date: Wed Sep 11 14:23:39 2019
New Revision: 371666
URL: http://llvm.org/viewvc/llvm-project?rev=371666&view=rev
Log:
[DWARF] Emit call site parameter info when tuning for lldb
Emit debug entry values using standard DWARF5 opcodes when the debugger
tuning is set to lldb.
Differential Revision: https://reviews.llvm.org/D67410
Modified:
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
llvm/trunk/test/DebugInfo/MIR/X86/debug-call-site-param.mir
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=371666&r1=371665&r2=371666&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Sep 11 14:23:39 2019
@@ -790,9 +790,9 @@ void DwarfDebug::constructCallSiteEntryD
CU.constructCallSiteEntryDIE(ScopeDIE, CalleeSP, IsTail, PCAddr,
PCOffset, CallReg);
- // For now only GDB supports call site parameter debug info.
+ // GDB and LLDB support call site parameter debug info.
if (Asm->TM.Options.EnableDebugEntryValues &&
- tuneForGDB()) {
+ (tuneForGDB() || tuneForLLDB())) {
ParamSet Params;
// Try to interpret values of call site parameters.
collectCallSiteParameters(&MI, Params);
Modified: llvm/trunk/test/DebugInfo/MIR/X86/debug-call-site-param.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/MIR/X86/debug-call-site-param.mir?rev=371666&r1=371665&r2=371666&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/MIR/X86/debug-call-site-param.mir (original)
+++ llvm/trunk/test/DebugInfo/MIR/X86/debug-call-site-param.mir Wed Sep 11 14:23:39 2019
@@ -1,4 +1,9 @@
-# RUN: llc -debug-entry-values -filetype=obj -mtriple=x86_64-unknown-unknown -start-after=machineverifier -o - %s| llvm-dwarfdump - | FileCheck %s
+# Test call site parameter encoding in DWARFv4.
+# When the debugger tuning is set to gdb, use GNU opcodes.
+# For lldb, use the standard DWARF5 opcodes.
+
+# RUN: llc -debug-entry-values -debugger-tune=gdb -filetype=obj -mtriple=x86_64-unknown-unknown -start-after=machineverifier -o - %s | llvm-dwarfdump - | FileCheck %s -check-prefixes=CHECK-GNU
+# RUN: llc -debug-entry-values -debugger-tune=lldb -filetype=obj -mtriple=x86_64-unknown-unknown -start-after=machineverifier -o - %s | llvm-dwarfdump - | FileCheck %s -check-prefixes=CHECK-DWARF5
#
# extern void foo(int *a, int b, int c, int d, int e, int f);
# extern int getVal();
@@ -8,36 +13,68 @@
# foo(&local1, arg2, 10, 15, arg3 + 3, arg1 + arg2);
# }
#
-# CHECK: DW_TAG_GNU_call_site
-# CHECK: DW_AT_abstract_origin {{.*}} "getVal"
+# CHECK-GNU: DW_TAG_GNU_call_site
+# CHECK-GNU: DW_AT_abstract_origin {{.*}} "getVal"
#
-# CHECK: DW_TAG_GNU_call_site
-# CHECK: DW_AT_abstract_origin {{.*}} "foo"
-# CHECK: DW_AT_low_pc {{.*}}
-# CHECK-EMPTY:
-# CHECK: DW_TAG_GNU_call_site_parameter
-# CHECK-NEXT: DW_AT_location (DW_OP_reg2 RCX)
-# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_lit15)
-# CHECK: DW_TAG_GNU_call_site_parameter
-# CHECK-NEXT: DW_AT_location (DW_OP_reg1 RDX)
-# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_lit10)
-# CHECK: DW_TAG_GNU_call_site_parameter
-# CHECK-NEXT: DW_AT_location (DW_OP_reg4 RSI)
-# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg3 RBX+0)
-# CHECK: DW_TAG_GNU_call_site_parameter
-# CHECK-NEXT: DW_AT_location (DW_OP_reg5 RDI)
-# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_fbreg +12)
-# CHECK: DW_TAG_GNU_call_site_parameter
-# CHECK-NEXT: DW_AT_location (DW_OP_reg9 R9)
-# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg15 R15+0, DW_OP_breg3 RBX+0, DW_OP_plus)
-# CHECK: DW_TAG_GNU_call_site_parameter
-# CHECK-NEXT: DW_AT_location (DW_OP_reg8 R8)
-# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg14 R14+3)
+# CHECK-GNU: DW_TAG_GNU_call_site
+# CHECK-GNU: DW_AT_abstract_origin {{.*}} "foo"
+# CHECK-GNU: DW_AT_low_pc {{.*}}
+# CHECK-GNU-EMPTY:
+# CHECK-GNU: DW_TAG_GNU_call_site_parameter
+# CHECK-GNU-NEXT: DW_AT_location (DW_OP_reg2 RCX)
+# CHECK-GNU-NEXT: DW_AT_GNU_call_site_value (DW_OP_lit15)
+# CHECK-GNU: DW_TAG_GNU_call_site_parameter
+# CHECK-GNU-NEXT: DW_AT_location (DW_OP_reg1 RDX)
+# CHECK-GNU-NEXT: DW_AT_GNU_call_site_value (DW_OP_lit10)
+# CHECK-GNU: DW_TAG_GNU_call_site_parameter
+# CHECK-GNU-NEXT: DW_AT_location (DW_OP_reg4 RSI)
+# CHECK-GNU-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg3 RBX+0)
+# CHECK-GNU: DW_TAG_GNU_call_site_parameter
+# CHECK-GNU-NEXT: DW_AT_location (DW_OP_reg5 RDI)
+# CHECK-GNU-NEXT: DW_AT_GNU_call_site_value (DW_OP_fbreg +12)
+# CHECK-GNU: DW_TAG_GNU_call_site_parameter
+# CHECK-GNU-NEXT: DW_AT_location (DW_OP_reg9 R9)
+# CHECK-GNU-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg15 R15+0, DW_OP_breg3 RBX+0, DW_OP_plus)
+# CHECK-GNU: DW_TAG_GNU_call_site_parameter
+# CHECK-GNU-NEXT: DW_AT_location (DW_OP_reg8 R8)
+# CHECK-GNU-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg14 R14+3)
+
+# CHECK-DWARF5: [[getValue_SP:.*]]: DW_TAG_subprogram
+# CHECK-DWARF5-NEXT: DW_AT_name ("getVal")
+
+# CHECK-DWARF5: [[foo_SP:.*]]: DW_TAG_subprogram
+# CHECK-DWARF5-NEXT: DW_AT_name ("foo")
+
+# CHECK-DWARF5: DW_TAG_call_site
+# CHECK-DWARF5: DW_AT_call_origin ([[getValue_SP]])
+#
+# CHECK-DWARF5: DW_TAG_call_site
+# CHECK-DWARF5: DW_AT_call_origin ([[foo_SP]])
+# CHECK-DWARF5: DW_AT_call_return_pc {{.*}}
+# CHECK-DWARF5-EMPTY:
+# CHECK-DWARF5: DW_TAG_call_site_parameter
+# CHECK-DWARF5-NEXT: DW_AT_location (DW_OP_reg2 RCX)
+# CHECK-DWARF5-NEXT: DW_AT_call_value (DW_OP_lit15)
+# CHECK-DWARF5: DW_TAG_call_site_parameter
+# CHECK-DWARF5-NEXT: DW_AT_location (DW_OP_reg1 RDX)
+# CHECK-DWARF5-NEXT: DW_AT_call_value (DW_OP_lit10)
+# CHECK-DWARF5: DW_TAG_call_site_parameter
+# CHECK-DWARF5-NEXT: DW_AT_location (DW_OP_reg4 RSI)
+# CHECK-DWARF5-NEXT: DW_AT_call_value (DW_OP_breg3 RBX+0)
+# CHECK-DWARF5: DW_TAG_call_site_parameter
+# CHECK-DWARF5-NEXT: DW_AT_location (DW_OP_reg5 RDI)
+# CHECK-DWARF5-NEXT: DW_AT_call_value (DW_OP_fbreg +12)
+# CHECK-DWARF5: DW_TAG_call_site_parameter
+# CHECK-DWARF5-NEXT: DW_AT_location (DW_OP_reg9 R9)
+# CHECK-DWARF5-NEXT: DW_AT_call_value (DW_OP_breg15 R15+0, DW_OP_breg3 RBX+0, DW_OP_plus)
+# CHECK-DWARF5: DW_TAG_call_site_parameter
+# CHECK-DWARF5-NEXT: DW_AT_location (DW_OP_reg8 R8)
+# CHECK-DWARF5-NEXT: DW_AT_call_value (DW_OP_breg14 R14+3)
+
--- |
; ModuleID = 'test.c'
source_filename = "test.c"
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
- target triple = "x86_64-unknown-linux-gnu"
; Function Attrs: nounwind uwtable
define dso_local void @baa(i32 %arg1, i32 %arg2, i32 %arg3) local_unnamed_addr !dbg !10 {
More information about the llvm-commits
mailing list