[PATCH] D67410: [DWARF] Emit call site parameter info when tuning for lldb

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 14:02:32 PDT 2019


dblaikie added a comment.

In D67410#1666891 <https://reviews.llvm.org/D67410#1666891>, @vsk wrote:

> The DWARFv5 forms were already the default choice when the tuning isn't set to GDB, this change is about allowing TAG_call_site_parameter to be emitted at all when the tuning is set to LLDB.


*nod*

> The idea is that, in the callee, we may now have variables which use DW_OP_entry_value, whereas before the patch that wouldn't have been the case. So the new entry value locations expand the ranges covered by AT_location.

This change (looking at the test changes, at least) looks to be about call_site tags, rather than entry_value?

Anyway, I haven't been paying close attention to the optimized debug info or these DWARFv5 location attributes - so don't mind me. Didn't mean to derail the review or anything.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67410/new/

https://reviews.llvm.org/D67410





More information about the llvm-commits mailing list