[PATCH] D67279: GlobalISel/AMDGPU: Legalize G_FMAD

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar accepted this revision.
aditya_nandakumar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1298
+  if (Ty == LLT::scalar(32) && !ST.hasFP32Denormals())
+    return true;
+  if (Ty == LLT::scalar(16) && !ST.hasFP16Denormals())
----------------
arsenm wrote:
> aditya_nandakumar wrote:
> > Won't ignoring this case here result in it failing the checks at the beginning of the instruction select where it probably will assert that this instruction is not legal (as it's custom).
> That check asserts isLegalOrCustom
Aah - I was looking at a different branch but I see that it's indeed LegalOrCustom in upstream.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67279/new/

https://reviews.llvm.org/D67279