[PATCH] D67372: [LV] Support invariant addresses in speculation logic

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a subscriber: anna.
Ayal added a comment.
This revision is now accepted and ready to land.

Thanks, just a minor nit.

Note that LICM'ing a uniform load may require introducing a 1st-order recurrence phi due to a subsequent store to same uniform address, as noted e.g. in the last test added by @anna in D54538 <https://reviews.llvm.org/D54538>.



================
Comment at: lib/Analysis/Loads.cpp:226
   // TODO: generalize to access patterns which have gaps
-  // TODO: handle uniform addresses (if not already handled by LICM)
   if (StepC != EltSize)
     return false;
----------------
nit: simply check `if (EltSize != Step->getAPInt())`? Admittedly relevant to previous patch, but seems more evident now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67372/new/

https://reviews.llvm.org/D67372