[PATCH] D67301: [LLD] Use the unified llvm demangle frontend function. NFC.
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 11 10:04:43 PDT 2019
sbc100 added inline comments.
================
Comment at: lld/COFF/Symbols.cpp:38
+ demangleInput.consume_front("_");
+ std::string demangled = demangle(demangleInput, /* StrictPrefix */ true);
+ if (demangled != demangleInput)
----------------
I think the convention is to use `/*StrictPrefix=*/true`. i.e. no spaces and an equals.
================
Comment at: lld/wasm/Symbols.cpp:303
std::string lld::toString(const wasm::Symbol &sym) {
- return lld::maybeDemangleSymbol(sym.getName());
-}
-
-std::string lld::maybeDemangleSymbol(StringRef name) {
- if (config->demangle)
- if (Optional<std::string> s = demangleItanium(name))
- return *s;
- return name;
+ return demangle(sym.getName(), /* StrictPrefix */ true);
}
----------------
Haven't we lost the checking of `config->demangle` here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67301/new/
https://reviews.llvm.org/D67301
More information about the llvm-commits
mailing list