[PATCH] D65267: [MachineCopyPropagation] Remove redundant copies after TailDup via machine-cp

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 08:44:40 PDT 2019


jsji added a comment.

> The patch is only updating existing tests in three places -- which to me looks more like a happy coincidence (that LLVM already includes tests that happen to trigger the new behavior) than intentional testing. Thanks!

`redundant-copy-after-tail-dup.ll` was newly added test (pre-committed) dedicated for this patch. 
But yes, it was mostly focus on positive testing, we should try to add more tests , 
especially due to the nature of `MachineCopyPropagation`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65267/new/

https://reviews.llvm.org/D65267





More information about the llvm-commits mailing list