[PATCH] D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls

[Jinsong Ji via Phabricator via llvm-commits]

jsji accepted this revision.
jsji added a comment.

LGTM.  May need @kbarton to have another look, as he should be in the "Must Review" for this.



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1413
+}
+                                               
+
----------------
Unnecessary extra newline.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:2065
+  assert(Res.getValueType() == N->getValueType(0) && 
+          (N->getNumValues() == 1 || N->isStrictFPOpcode()) &&
          "Invalid operand expansion");
----------------
Is this formatted by clang-format? Extra space at the end of line here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64662/new/

https://reviews.llvm.org/D64662