[PATCH] D67411: [InstSimplify] simplifyUnsignedRangeCheck(): handle more cases (PR43251)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 4 inline comments as done.
lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:1774-1775
   if (ICmp0 && ICmp1)
-    V = IsAnd ? simplifyAndOfICmps(ICmp0, ICmp1, Q.IIQ, Q.DL)
-              : simplifyOrOfICmps(ICmp0, ICmp1, Q.IIQ, Q.DL);
+    V = IsAnd ? simplifyAndOfICmps(ICmp0, ICmp1, Q)
+              : simplifyOrOfICmps(ICmp0, ICmp1, Q);
 
----------------
spatel wrote:
> lebedev.ri wrote:
> > spatel wrote:
> > > Can the diffs to thread the full SimplifyQuery through the calls be done as a preliminary step?
> > > I'm not sure how to expose a diff in a test, but I'd think it's not quite 'NFC', so it should be an independent change.
> > I actually messed up in D67332, i didn't actually mean to *only* pass DL, it just kind-of fell through cracks :/
> > So passing `SimplifyQuery` is actually *intended* as NFC, but then i'm trying to balance
> > between having too much patches, and having too big patches.
> > Let me see if i can come up with a test.
> I'm fine with just changing the code by inspection as a preliminary to this patch; it's clearly an improvement.
Done in rL371630, will rebase in a sec.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67411/new/

https://reviews.llvm.org/D67411