[PATCH] D67446: [ConstProp] allow folding for fma that produces NaN

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 08:07:16 PDT 2019


cameron.mcinally accepted this revision.
cameron.mcinally added inline comments.


================
Comment at: llvm/test/Transforms/ConstProp/fma.ll:196
   ret double %1
 }
 
----------------
cameron.mcinally wrote:
> Should this class of FMA return poison? There's no valid result for fma(0, inf, C), where C != NaN.
> 
> @eli.friedman 
Bah, never mind. That only applies to converts that return integer results. FP results are defined as NaNs.

```
For operations producing results in floating-point format, the default result of an operation that signals the invalid operation exception shall be a quiet NaN that should provide some diagnostic information (see 6.2).
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67446/new/

https://reviews.llvm.org/D67446





More information about the llvm-commits mailing list