[PATCH] D63676: Early exit from Hoist() in machine licm pass based on block hotness

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Just passing-by remark: i find naming schemes in this patch very confusing:

- The patch subject should talk about not hoisting into hotter blocks, not about early out
- `due to block hotness` is very meaningless to me. I suspect most of the occurrences of that phrase should actually be closer to `because destination block is hotter`



================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:81-82
+BlockFrequencyRatioThreshold("block-freq-ratio-threshold",
+		             cl::desc("Block frequency ratio threshold to "
+			              "disable instruction hoisting"),
+		             cl::init(100), cl::Hidden);
----------------
It isn't really obvious whether larger value relaxes this check or the other way around


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676