[PATCH] D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file.

[Max Moroz via Phabricator via llvm-commits]

Dor1s added inline comments.


================
Comment at: lib/fuzzer/FuzzerDefs.h:196
 
+template<typename T>
+using UnorderedSet =
----------------
Dor1s wrote:
> morehouse wrote:
> > Dor1s wrote:
> > > kcc wrote:
> > > > any reason to do this? 
> > > > we had the special types for Vector/Set due to the problem which we don't have anymore
> > > > (we solved it by using a privatized STL)
> > > Not really, I just thought I would follow that pattern of pre-defining STL container types using `fuzzer_allocator`. I'm fine to get rid of it, if you prefer.
> > Please remove it.
> Discussed offline. I'll remove this change after Matt's review.
Done


================
Comment at: lib/fuzzer/FuzzerMerge.cpp:332
+          exit(0);
+        } else {
+          // Number of input files likely changed, start merge from scratch, but
----------------
morehouse wrote:
> Nit: let's omit the else for less nesting since the if short-circuits
Done


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66107/new/

https://reviews.llvm.org/D66107