[PATCH] D67417: [LICM/AST] Check if the AliasAny set is removed from the tracker.

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: lib/Analysis/AliasSetTracker.cpp:707
     AS.print(OS);
   OS << "\n";
 }
----------------
Nit: Wouldn't mind if we added a printout here to indicate when we have the AliasAny set (as that was helpful when debugging). I used something like this:
```
  if (AliasAnyAS)
    OS << "Saturated!\n";
```


================
Comment at: test/Transforms/LICM/pr38513.ll:1
+; RUN: opt -enable-mssa-loop-dependency=false -disable-basicaa -alias-set-saturation-threshold=2 -licm -S %s | FileCheck %s
+; REQUIRES: asserts
----------------
It is recommended to use redirect for the input to opt (https://llvm.org/docs/TestingGuide.html#fragile-tests):

; RUN: opt < %s -enable-mssa-loop-dependency=false -disable-basicaa -alias-set-saturation-threshold=2 -licm -S | FileCheck %s


================
Comment at: test/Transforms/LICM/pr38513.ll:3
+; REQUIRES: asserts
+
+define void @f1() {
----------------
uabelho wrote:
> Add a few CHECKs here perhaps?
> Right now FileCheck complains there are none:
> ```
> error: no check strings found with prefix 'CHECK:'
> ```
Yes, CHECK:s are needed. And then "REQUIRES: asserts" can be removed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67417/new/

https://reviews.llvm.org/D67417