[PATCH] D67287: [Diagnostics] Add -Wsizeof-array-div

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D67287#1665215 <https://reviews.llvm.org/D67287#1665215>, @xbolva00 wrote:

> Thanks for review/advices!


It seems you committed in a hurry. This adds a new enabled-by-default warning which can break people's builds if they have -Werror. I don't know who will be broken but I think you probably needs a thumbs-up before committing.



================
Comment at: cfe/trunk/test/Sema/div-sizeof-array.cpp:1
+// RUN: %clang_cc1 %s -verify -Wsizeof-array-div -fsyntax-only
+
----------------
For enabled-by-default warnings, I guess it may be nice to have another RUN line without -Wsizeof-array-div.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67287/new/

https://reviews.llvm.org/D67287