[PATCH] D67343: [DebugInfo] Change object::RelocationResolver to return Expected<uint64_t>

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 03:32:12 PDT 2019


MaskRay updated this revision to Diff 219683.
MaskRay marked an inline comment as done.
MaskRay added a comment.

Address review comments

(Last update sent too fast. I still prefer multi repo but have to use a monorepo as the change touches lld - I know that the world is moving toward a monorepo - I just don't like pulling in lots of unrelevant changes with a monorepo)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67343/new/

https://reviews.llvm.org/D67343

Files:
  lld/ELF/DWARF.cpp
  llvm/include/llvm/Object/RelocationResolver.h
  llvm/lib/DebugInfo/DWARF/DWARFDataExtractor.cpp
  llvm/lib/Object/RelocationResolver.cpp
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67343.219683.patch
Type: text/x-patch
Size: 13896 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190911/4fe5018c/attachment.bin>


More information about the llvm-commits mailing list