[PATCH] D67410: [DWARF] Emit call site parameter info when tuning for lldb

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 11 00:01:16 PDT 2019


djtodoro added a comment.

Thanks for this! I am so exciting to see this implemented. :)

LGTM as well.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:793
 
-      // For now only GDB supports call site parameter debug info.
+      // For now only GDB and LLDB support call site parameter debug info.
       if (Asm->TM.Options.EnableDebugEntryValues &&
----------------
aprantl wrote:
> Let's remove the "For now only" part. That's a fairly large percentage of developers :-)
+1 :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67410/new/

https://reviews.llvm.org/D67410





More information about the llvm-commits mailing list