[PATCH] D66107: [libFuzzer] Make -merge=1 to reuse coverage information from the control file.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 15:15:22 PDT 2019


morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/fuzzer/FuzzerDefs.h:196
 
+template<typename T>
+using UnorderedSet =
----------------
Dor1s wrote:
> kcc wrote:
> > any reason to do this? 
> > we had the special types for Vector/Set due to the problem which we don't have anymore
> > (we solved it by using a privatized STL)
> Not really, I just thought I would follow that pattern of pre-defining STL container types using `fuzzer_allocator`. I'm fine to get rid of it, if you prefer.
Please remove it.


================
Comment at: lib/fuzzer/FuzzerMerge.cpp:332
+          exit(0);
+        } else {
+          // Number of input files likely changed, start merge from scratch, but
----------------
Nit: let's omit the else for less nesting since the if short-circuits


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66107/new/

https://reviews.llvm.org/D66107





More information about the llvm-commits mailing list