[PATCH] D67387: Move LLVM_ENABLE_ABI_BREAKING_CHECKS to its own file

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 15:06:26 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL371561: Move LLVM_ENABLE_ABI_BREAKING_CHECKS variables to their own file (authored by echristo, committed by ).
Herald added a subscriber: kristina.

Changed prior to commit:
  https://reviews.llvm.org/D67387?vs=219485&id=219613#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67387/new/

https://reviews.llvm.org/D67387

Files:
  llvm/trunk/lib/Support/ABIBreak.cpp
  llvm/trunk/lib/Support/CMakeLists.txt
  llvm/trunk/lib/Support/Error.cpp
  llvm/trunk/utils/gn/secondary/llvm/lib/Support/BUILD.gn


Index: llvm/trunk/utils/gn/secondary/llvm/lib/Support/BUILD.gn
===================================================================
--- llvm/trunk/utils/gn/secondary/llvm/lib/Support/BUILD.gn
+++ llvm/trunk/utils/gn/secondary/llvm/lib/Support/BUILD.gn
@@ -29,6 +29,7 @@
   ]
   sources = [
     "AArch64TargetParser.cpp",
+    "ABIBreak.cpp",
     "AMDGPUMetadata.cpp",
     "APFloat.cpp",
     "APInt.cpp",
Index: llvm/trunk/lib/Support/Error.cpp
===================================================================
--- llvm/trunk/lib/Support/Error.cpp
+++ llvm/trunk/lib/Support/Error.cpp
@@ -167,18 +167,3 @@
 LLVMErrorTypeId LLVMGetStringErrorTypeId() {
   return reinterpret_cast<void *>(&StringError::ID);
 }
-
-#ifndef _MSC_VER
-namespace llvm {
-
-// One of these two variables will be referenced by a symbol defined in
-// llvm-config.h. We provide a link-time (or load time for DSO) failure when
-// there is a mismatch in the build configuration of the API client and LLVM.
-#if LLVM_ENABLE_ABI_BREAKING_CHECKS
-int EnableABIBreakingChecks;
-#else
-int DisableABIBreakingChecks;
-#endif
-
-} // end namespace llvm
-#endif
Index: llvm/trunk/lib/Support/ABIBreak.cpp
===================================================================
--- llvm/trunk/lib/Support/ABIBreak.cpp
+++ llvm/trunk/lib/Support/ABIBreak.cpp
@@ -0,0 +1,24 @@
+//===----- lib/Support/ABIBreak.cpp - EnableABIBreakingChecks -------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/Config/abi-breaking.h"
+
+#ifndef _MSC_VER
+namespace llvm {
+
+// One of these two variables will be referenced by a symbol defined in
+// llvm-config.h. We provide a link-time (or load time for DSO) failure when
+// there is a mismatch in the build configuration of the API client and LLVM.
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
+int EnableABIBreakingChecks;
+#else
+int DisableABIBreakingChecks;
+#endif
+
+} // end namespace llvm
+#endif
Index: llvm/trunk/lib/Support/CMakeLists.txt
===================================================================
--- llvm/trunk/lib/Support/CMakeLists.txt
+++ llvm/trunk/lib/Support/CMakeLists.txt
@@ -53,6 +53,7 @@
 
 add_llvm_library(LLVMSupport
   AArch64TargetParser.cpp
+  ABIBreak.cpp
   ARMTargetParser.cpp
   AMDGPUMetadata.cpp
   APFloat.cpp


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67387.219613.patch
Type: text/x-patch
Size: 2524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190910/5bb9f991/attachment.bin>


More information about the llvm-commits mailing list