[llvm] r371555 - llvm-reduce: Simplify testing using -implicit-check-not

[David Blaikie via llvm-commits]

Author: dblaikie
Date: Tue Sep 10 13:52:14 2019
New Revision: 371555

URL: http://llvm.org/viewvc/llvm-project?rev=371555&view=rev
Log:
llvm-reduce: Simplify testing using -implicit-check-not

Also fix llvm-reduce to use the specified output file name directly,
without appending '.ll' to the name.

Modified:
    llvm/trunk/test/Reduce/remove-funcs.ll
    llvm/trunk/test/Reduce/remove-global-vars.ll
    llvm/trunk/tools/llvm-reduce/llvm-reduce.cpp

Modified: llvm/trunk/test/Reduce/remove-funcs.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Reduce/remove-funcs.ll?rev=371555&r1=371554&r2=371555&view=diff
==============================================================================
--- llvm/trunk/test/Reduce/remove-funcs.ll (original)
+++ llvm/trunk/test/Reduce/remove-funcs.ll Tue Sep 10 13:52:14 2019
@@ -10,10 +10,10 @@
 ; then include the rest of the test script
 ; RUN: cat %p/Inputs/remove-funcs.py >> %t/test.py
 
-; RUN: llvm-reduce --test %t/test.py %s -o - | FileCheck %s
+; RUN: llvm-reduce --test %t/test.py %s -o %t/out.ll
+; RUN: cat %t/out.ll | FileCheck -implicit-check-not=uninteresting %s
 ; REQUIRES: plugins
 
-; CHECK-NOT: uninteresting1()
 define i32 @uninteresting1() {
 entry:
   ret i32 0
@@ -24,16 +24,13 @@ define i32 @interesting() {
 entry:
   ; CHECK: call i32 @interesting()
   %call2 = call i32 @interesting()
-  ; CHECK-NOT: call i32 @uninteresting1()
   %call = call i32 @uninteresting1()
   ret i32 5
 }
 
-; CHECK-NOT: uninteresting2()
 define i32 @uninteresting2() {
 entry:
   ret i32 0
 }
 
-; CHECK-NOT: uninteresting3()
 declare void @uninteresting3()

Modified: llvm/trunk/test/Reduce/remove-global-vars.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Reduce/remove-global-vars.ll?rev=371555&r1=371554&r2=371555&view=diff
==============================================================================
--- llvm/trunk/test/Reduce/remove-global-vars.ll (original)
+++ llvm/trunk/test/Reduce/remove-global-vars.ll Tue Sep 10 13:52:14 2019
@@ -10,24 +10,22 @@
 ; then include the rest of the test script
 ; RUN: cat %p/Inputs/remove-global-vars.py >> %t/test.py
 
-; RUN: llvm-reduce --test %t/test.py %s -o - | FileCheck %s
+; RUN: llvm-reduce --test %t/test.py %s -o %t/out.ll
+; RUN: cat %t/out.ll | FileCheck -implicit-check-not=uninteresting %s
 ; REQUIRES: plugins
 
 ; CHECK: @interesting = global
 @interesting = global i32 0, align 4
-; CHECK-NOT: global
 @uninteresting = global i32 1, align 4
 
 define i32 @main() {
 entry:
-  ; CHECK-NOT: load i32, i32* @uninteresting, align 4
   %0 = load i32, i32* @uninteresting, align 4
   ; CHECK: store i32 undef, i32* @interesting, align 4
   store i32 %0, i32* @interesting, align 4
 
   ; CHECK: load i32, i32* @interesting, align 4
   %1 = load i32, i32* @interesting, align 4
-  ; CHECK-NOT: store i32 %1, i32* @uninteresting, align 4
   store i32 %1, i32* @uninteresting, align 4
 
   ; CHECK: %inc = add nsw i32 undef, 1

Modified: llvm/trunk/tools/llvm-reduce/llvm-reduce.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-reduce/llvm-reduce.cpp?rev=371555&r1=371554&r2=371555&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-reduce/llvm-reduce.cpp (original)
+++ llvm/trunk/tools/llvm-reduce/llvm-reduce.cpp Tue Sep 10 13:52:14 2019
@@ -99,8 +99,6 @@ int main(int argc, char **argv) {
         OutputFilename = InputFilename.c_str();
       else if (OutputFilename.empty())
         OutputFilename = "reduced.ll";
-      else
-        OutputFilename += ".ll";
 
       sys::fs::copy_file(Tester.getReducedFilepath(), OutputFilename);
       errs() << "\nDone reducing! Reduced testcase: " << OutputFilename << "\n";