[PATCH] D67376: [DWARF] Evaluate DW_OP_entry_value

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 13:33:05 PDT 2019


grandinj added inline comments.


================
Comment at: lldb/include/lldb/Symbol/Function.h:258
+
+using CallSiteParameterArray = std::unique_ptr<std::vector<CallSiteParameter>>;
+
----------------
the way this is being used seems to indicate it can be 
   std::vector<CallSiteParameter>
no need for unique_ptr


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67376/new/

https://reviews.llvm.org/D67376





More information about the llvm-commits mailing list