[PATCH] D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 12:11:12 PDT 2019


arsenm added a comment.

Tests?



================
Comment at: llvm/lib/IR/Core.cpp:3643-3645
   Value *P = unwrap<Value>(MemAccessInst);
   if (LoadInst *LI = dyn_cast<LoadInst>(P))
     return LI->isVolatile();
----------------
Unrelated problem, but this won't catch memory intrinsics with volatile set. I also think there's another copy of this somewhere


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67132/new/

https://reviews.llvm.org/D67132





More information about the llvm-commits mailing list