[PATCH] D66322: [X86] Updated target specific selection dag code to conservatively check for isAtomic in addition to isVolatile

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 10 11:31:10 PDT 2019


reames added a comment.

In D66322#1663992 <https://reviews.llvm.org/D66322#1663992>, @craig.topper wrote:

> LGTM.  Will you also be updating nonvolatile_load/nonvolatile_store in include/llvm/Target/TargetSelectionDAG.td. We use those in several places where we change the size of a load.


This'll be under a separate review, but yes.   See D66318 <https://reviews.llvm.org/D66318>.  (I'll move your comment there.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66322/new/

https://reviews.llvm.org/D66322





More information about the llvm-commits mailing list